vue-bootstrap-typeahead icon indicating copy to clipboard operation
vue-bootstrap-typeahead copied to clipboard

fix: check for value at start and watch for external changes

Open raymondmuller opened this issue 5 years ago • 8 comments

Got this issue that you can't preset the value. This fixes it.

Demonstrated in this pen: https://codepen.io/raymondmuller/pen/pxgXzd

the value of 'query' is 'test', however the input does not reflect it.

also watching the value afterwards to make it respond to external changes

raymondmuller avatar Oct 03 '18 17:10 raymondmuller

Pull Request Test Coverage Report for Build 39

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 69.697%

Totals Coverage Status
Change from base Build 38: 0.3%
Covered Lines: 48
Relevant Lines: 69

💛 - Coveralls

coveralls avatar Oct 03 '18 17:10 coveralls

Please implement ASAP, much needed!

Centro1993 avatar Dec 06 '18 13:12 Centro1993

Please accept and release new minor version. Thanks!

brweber2 avatar Dec 12 '18 04:12 brweber2

Please accept this PR!

rlightner avatar Jan 12 '19 03:01 rlightner

Can this get merged?

siamkreative avatar Mar 07 '19 13:03 siamkreative

ran into issue when binding the autocomplete in a vue for loop and dynamically adding a new record to my array on button click. Changing the below corrected.

inputValue: this.value
to
inputValue: this.value || ''

dallasbeek avatar Mar 12 '19 17:03 dallasbeek

@alexurquhart Do you have time to review this PR?

siamkreative avatar Mar 13 '19 03:03 siamkreative

Thanks for looking into this and submitting!

I merged in functionality that I think meets this need here: mattzollinhofer@e26ad49.

You can use the functionality under the forked project: https://www.npmjs.com/package/vue-typeahead-bootstrap or https://github.com/mattzollinhofer/vue-typeahead-bootstrap.

Hope this helps anyone who needs this functionality going forward! Let me know if that fix doesn't fix this issue.

mattzollinhofer avatar Feb 23 '20 05:02 mattzollinhofer