vue-bootstrap-typeahead
vue-bootstrap-typeahead copied to clipboard
fix: check for value at start and watch for external changes
Got this issue that you can't preset the value. This fixes it.
Demonstrated in this pen: https://codepen.io/raymondmuller/pen/pxgXzd
the value of 'query' is 'test', however the input does not reflect it.
also watching the value afterwards to make it respond to external changes
Pull Request Test Coverage Report for Build 39
- 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.3%) to 69.697%
Totals | |
---|---|
Change from base Build 38: | 0.3% |
Covered Lines: | 48 |
Relevant Lines: | 69 |
💛 - Coveralls
Please implement ASAP, much needed!
Please accept and release new minor version. Thanks!
Please accept this PR!
Can this get merged?
ran into issue when binding the autocomplete in a vue for loop and dynamically adding a new record to my array on button click. Changing the below corrected.
inputValue: this.value
to
inputValue: this.value || ''
@alexurquhart Do you have time to review this PR?
Thanks for looking into this and submitting!
I merged in functionality that I think meets this need here: mattzollinhofer@e26ad49.
You can use the functionality under the forked project: https://www.npmjs.com/package/vue-typeahead-bootstrap or https://github.com/mattzollinhofer/vue-typeahead-bootstrap.
Hope this helps anyone who needs this functionality going forward! Let me know if that fix doesn't fix this issue.