easyappointments icon indicating copy to clipboard operation
easyappointments copied to clipboard

Secretaries didn't received appointments notification

Open rankun203 opened this issue 8 years ago • 3 comments

I have Receive Notification on in a secretary settings, the secretary are connected to a provider, but when I use another email to make an appointment to that specific provider, the secretary received no email.

Will secretaries receive appointments notification of connected providers?

rankun203 avatar Dec 11 '16 07:12 rankun203

Hi, yeah this is a necessary setting. I wanted to implement this before but I guess it's just forgotten due to other task or feature implementations. Will mark it as a feature for an upcoming release.

  Alex Tselegidis, Easy!Appointments Creator
  Need a customization? Contact me in person!

alextselegidis avatar Dec 13 '16 23:12 alextselegidis

Hi! Any news on this issue ? Thanks ...

lucacalcaterra avatar Jun 05 '20 11:06 lucacalcaterra

The logic seems to be wrong here: https://github.com/alextselegidis/easyappointments/blob/1700605b7b31c031d9c8a9697ab987cea2b0e8d7/application/libraries/Notifications.php#L133-L136

It should be inverted so that we do not skip the email if the provider is in the secretary's list of providers:

if (! in_array($provider['id'], $secretary['providers']))
                {
                    continue;
                }

(I changed this in my installation, and now the secretary recevives email.)

RaphaelWimmer avatar Feb 17 '21 19:02 RaphaelWimmer