ARChromeActivity icon indicating copy to clipboard operation
ARChromeActivity copied to clipboard

Better url escape

Open mureev opened this issue 10 years ago • 2 comments

I can suggest to use "@"!'"();:@&=+$,/?%#[]% " instead of "@"!'();:@&=+$,/?%#[]" in encodeByAddingPercentEscapes methos

mureev avatar Mar 04 '14 13:03 mureev

What situations does the current one fail under?

I'm just not sure how an NSURL would have an unescaped quote in it. In this example below, urlToShare is nil because NSURL expects to be given a valid URL.

NSURL *urlToShare = [NSURL URLWithString:@"http://example.com/\"quotes\"/"];

alextrob avatar Mar 05 '14 08:03 alextrob

I get this string from stakoverflow a long time ago and I don't know about quotes too. But there is more important difference - space char;

mureev avatar Mar 05 '14 08:03 mureev