node-phantom icon indicating copy to clipboard operation
node-phantom copied to clipboard

Published 20 hours ago • verified publisher icon alexscheelmeyer

Remove unwrapArray

Open vmeurisse opened this issue 11 years ago • 1 comments

This caused API of page.onResourceRequested to change with phantom 1.9.0 (first argument was request, it became an array [request, networkRequest]).

Now use fn.apply to pass arguments as they are received. This ensure that any change in phantomjs is transparently reflected without interference from node-phantom.

NOTE: This change the API of onError and onPrompt which where already affected by this bug. They now get the same parameters as described on https://github.com/ariya/phantomjs/wiki/API-Reference-WebPage.

vmeurisse avatar May 02 '13 23:05 vmeurisse

I like this. It is however a change that would break existing code so I will meditate some more on this.

alexscheelmeyer avatar May 22 '13 10:05 alexscheelmeyer