fest-assert-2.x

fest-assert-2.x copied to clipboard

IterableAssert.startsWith checks size of actual iterable: if (sizeOf(actual) < sequenceSize) { this causes infinite loop for inifinite iterables. Test case: ``` public void shouldNotEvaluateAllCollection() throws Exception { Iterable list =...

mpi

Arrays.assertContainsSequence stops after 1st potential match

1

Let's say I have an array that looks like this: ``` String[] array = new String[] { "--option", "a=b", "--option", "c=d" }; ``` I want to assert that the array...

dloose

IterableAssert.doesNotHaveDuplicates became unsable with many elements

1

Hello, I used fest in my projects at a snapshot version : 44bf124d011b0f35a3add2be57a30fd8a372876a FEST-258 : fix NPE that would occur if error stack trace filtering is enabled and we JUnit...

thomas-hilaire

Feature request: extractProperty() to use fields directly

7

Any chance we could have extractProperty() fall back to supporting fields when a getter doesn't exist. E.g. ``` java class Animal { public String name; } ```

japgolly

Var args for StringAssert::contains()

2

Recently I've found myself doing this: ``` String json = getPolicyInfoFromRemoteSystem(); assertThat(json) .contains("{") .contains("}") .contains("coverages"); ``` Yes, I could use a regex, but then it looks like this: ``` assertThat(json)...

tedyoung

Add osgi metadata to MANIFEST

2

In order to be usable by osgi project (for example an Eclipse plugin using tycho) it is required to provide some metadata in MANIFEST. I will try to submit a...

henryju

Make custom assertions easier to write

2

For the time being, writing an assertion in its own assertion class looks like : ``` java public TolkienCharacterAssert hasAge(int age) { // use existing WritableAssertionInfo to set a specific...

joel-costigliola

Iterables.assertContainsExactly should not throw ex. if 'actual' and 'values' are empty

5

`org.fest.assertions.internal.Iterables.assertContainsExactly(AssertionInfo info, Iterable actual, Object[] values)` calls checkIsNotNullAndNotEmpty(values) and throws an IllegalArgumentException with message "The array of values to look for should not be empty" EVEN if values AND actual...

mkarneim

Add StringAssert.containsSequence

3

In the same idea as issue 120 https://github.com/alexruiz/fest-assert-2.x/issues/120 It would nice to be able to test that different portions of a string appears in order (whatever is between them). So...

bric3

This has been done in [fest-guava-assert](https://github.com/joel-costigliola/fest-guava-assert) for example. The plugin should certainly be declared in fest parent pom

joel-costigliola