Alejandro Rodríguez Salamanca
Alejandro Rodríguez Salamanca
Yeah, makes sense! I'll start to work on this ASAP
Hey @jdm. I've been reading the code and I think that it needs a big refactor to be fully testable, although it will be a big project. This is my...
Yeah, that's definitely tricky. I still have to understand the code better to be able to answer that question properly.
Hey! I'm still working on this. I've extracted some logic from `parse_commands` to its own methods to be able to mock the state. This is only the first step to...
Hi! > the tests for unverified behavior aren't really useful I agree with that, but reintroducing verification into the methods isn't possible because I can't mock the verification function for...
I'll try that! Anyway, if I understand correctly (and correct me if I'm wrong), the use of partial isn't necessary. We can just call `verify_auth` with the same arguments we...
Thanks for reporting it! I'll look into it.
@kennytm Can you show me a PR where this happens?
I've been busy lately, but I'll look into this ASAP.
I've been comparing `0979fe7`with the latest `master` (https://github.com/servo/homu/compare/0979fe7151a43fabd4925187ab1f97100bf4d400...master) and I don't see where this problem could have been introduced...