Alex Rønne Petersen

Results 853 comments of Alex Rønne Petersen

I'm not sure how to handle the classic ESC ambiguity in input parsing. You can only use brittle heuristics (e.g. input buffer size or timing) to attempt to distinguish an...

https://github.com/alexrp/system-terminal/blob/acc9de6d5a63025bb9278b4817c9e265513b3089/src/core/IO/TerminalReader.cs#L81-L95

(It seems like only `ReadLineAsync` will get a `CancellationToken` overload.)

Need to determine what to do about `ReadLine`...

It might make the most sense to just not support cancellation in synchronous methods. That seems to be the norm throughout the BCL.

That's most likely unrelated and could be related to the recently-added cancellation support. Would you mind filing a separate issue with more info? (Library version, Windows version, etc.)

This is going to require some work in CsWin32, so probably won't happen immediately when .NET 7 is out.

Blocked on: https://github.com/microsoft/CsWin32/issues/600

Started a discussion: microsoft/terminal#12143

(It finally finished after 28 hours and shrunk the BNDB to ~360 MB.)