currencyconverter icon indicating copy to clipboard operation
currencyconverter copied to clipboard

Feat/get exchange rate

Open Sigularusrex opened this issue 1 year ago • 3 comments

It would be great to make fetching rates a little more explicit. If you agree, I'll update the readme too.

For now, tests are failing on my repo

Sigularusrex avatar Nov 11 '23 22:11 Sigularusrex

Thanks for the idea. I wonder if this is really useful though, as it is basically a partial on c.convert().

alexprengere avatar Nov 14 '23 14:11 alexprengere

@alexprengere thanks for checking this.

You're right, it makes fetching rates a little more explicit rather than having to derive the conversion rate from c.convert(1 'EUR', 'NOK')

I think it's a nice quality of life improvement to have a separate function for this, so you can c.get_exchange_rate('EUR' 'NOK')

But it's your call. lmk if you'd like to continue or feel free to close the PR.

Sigularusrex avatar Nov 16 '23 17:11 Sigularusrex