material-ui-banner icon indicating copy to clipboard operation
material-ui-banner copied to clipboard

Published 20 hours ago • verified publisher icon alexplumb

Provide @types/material-ui-banner

Open flyrev opened this issue 5 years ago • 2 comments

Using this in a React+TypeScript project, I get

error TS7016: Could not find a declaration file for module 'material-ui-banner'. 'node_modules/material-ui-banner/dist/index.js' implicitly has an 'any' type.
  Try `npm install @types/material-ui-banner` if it exists or add a new declaration (.d.ts) file containing `declare module 'material-ui-banner';`

flyrev avatar Nov 27 '19 15:11 flyrev

Hi @flyrev thanks for the issue. I'm not particularly well versed in Typescript for the front-end, but I'd be happy to accept a merge request from an enterprising individual that was willing to write a d.ts file for the project.

alexplumb avatar Dec 05 '19 15:12 alexplumb

Would you be interested in a Typescript rewrite instead? I'm willing to convert the files; I don't think that much would even need to change. You're using ES6 imports, webpack, etc. Having a separate .d.ts file would probably require more code, and you'd have to maintain it with any future updates.

mattcasey avatar Feb 25 '21 17:02 mattcasey