wro4j icon indicating copy to clipboard operation
wro4j copied to clipboard

taglib seeks to resolve wildcards even if exploded is false

Open simoami opened this issue 12 years ago • 3 comments

Hi Alex,

First of all, this issue is manifesting with wro4j-taglib but I have a feeling it is directly related to wro4j and warnings are being fired from the core library.

We package our app into a war and deploy it. The package includes all the minified bundles but excludes the source files. we don't need sources in QA and production environments.

When deployed, the app runs as expected and the JS bundles are served as expected, but the logs are being filled up with warnings as wro4j attempts to resolve some wildcards in our wro group definitions and does't find the corresponding sources. This is not necessary when the taglib is configured with exploded=false.

I think this happens when an instance of the wroModel is created: helper.getManagerFactory().create().getModelFactory().create();

Here's a subset of the log:

DEBUG  (JCLLoggerAdapter.java:188) - Expanding resource: /javascript/ga/*.js
DEBUG  (JCLLoggerAdapter.java:188) - computeBaseNameFolder for resource ro.isdc.wro.model.resource.Resource@343947c[JS,/javascript/ga/*.js,true]
DEBUG  (JCLLoggerAdapter.java:188) - resourcePath: /javascript/ga/**
DEBUG  (JCLLoggerAdapter.java:188) - locate resource: /javascript/ga/**
WARN   (JCLLoggerAdapter.java:379) - [FAIL] localize the stream containing wildcard. Original error message: 'Invalid folder provided, with path: /workspace/trunk/dashboard/web/target/project-web-4-SNAPSHOT/javascript/ga, with fileNameWithWildcard: /javascript/ga/**".
 Trying to locate the stream without the wildcard.'

Note: the debug statements are to help understand where it's failing. But it's the WARN entries I'm after.

simoami avatar Dec 26 '12 19:12 simoami

what wro4j version are you using? I have a feeling that this was fixed in one of the most recent releases.

alexo avatar Dec 27 '12 22:12 alexo

wro4j: 1.6.1 wro4j-taglib: 1.2

simoami avatar Dec 27 '12 22:12 simoami

ok, so it stil does not work in most recent release. Could you create a quick start project or at least describe the reproduction path when using no taglib?

Thanks On Dec 28, 2012 12:53 AM, "simoami" [email protected] wrote:

wro4j: 1.6.1 wro4j-taglib: 1.2

— Reply to this email directly or view it on GitHubhttps://github.com/alexo/wro4j/issues/83#issuecomment-11720623.

alexo avatar Dec 27 '12 22:12 alexo