DispatcherStreamLocator erroneously computes servletContextPath

[andredasilvapinto]

https://github.com/alexo/wro4j/blob/1.7.x/wro4j-core/src/main/java/ro/isdc/wro/model/resource/locator/support/DispatcherStreamLocator.java#L106

is not a valid way to compute the servletContextPath.

Consider: Request url: http://foo.bar:80/resources/some.css Servlet path: "" Location: /some_other.css

The resulting request will be made to http://foo.bar:80/resources/some.css/some_other.css which is obviously wrong.

Alternatively the servletContextPath can be computed by using something like:

request.getScheme() + "://" + request.getServerName() + ":" + request.getServerPort() + request.getContextPath();

I'm also not sure https://github.com/alexo/wro4j/blob/1.7.x/wro4j-core/src/main/java/ro/isdc/wro/model/resource/locator/support/DispatcherStreamLocator.java#L92 is the best way to identify errors with the dispatcher location. A valid resource can simply be empty.

[alexo]

Thanks for reporting this.

Regarding empty resources, don't you agree that inncluding an empty resource is an exceptional use case?

[andredasilvapinto]

It's not very common, I agree. But it may happen (it actually did in our project). I think conceptually "not found" and "empty" should be treated differently, but it is not that bad I guess.