Alex McCabe

Results 31 comments of Alex McCabe

@bakerkretzmar I tried to do that with the `KnownRouteParamsObject`, but it just marks them as potentially being undefined, which doesn't allow for not including them. I wonder if I could...

So I have managed to [get this far](https://www.typescriptlang.org/play?#code/FAFwngDgpgBACgQwE4ILZRFJBJAdgMwHsYBeGAbxlzSgC4YBnEJAS1wHMBuGQiEFwtQA29AEaFCQqAlzdRbACZt2AfnpNWHGAF9OoSLAAiUfAgCuQkACVCZkAlFTSFGCwXrmymAB8qZ1KJYOjAAZDBWUADGhEgKADwA1lBghPgwMmAANDBmuAm4hADuuAB8euDQ8Mg0mEgAaghCZrBkGl6+uP6BSD4wxqYW1rb2jlB6wPqVNnYOUnHYMFAAHpi4CgxVKOi1eEQlzgvLq+su8mvKHprsOsAwdzAqLgDaANKuuDDYTwDkZ0oc3wAuoDLu0-AEgtpem0tB0ulhbvd6IgthgsA0mmMJgB6bEwAC0hKJxMJkTsRImk1geAgdmcT0o1HQ9G+REI324vH4gka9FMQgYsG02UZNBZomQHJ4fAEwnozGaOkB4wqsBR-EaQjAAHkZTyhHEACrZN5HKBrDZJFJpQ37Mja1AsEBGk37MLqliNOJwFiRBIumAvEplCaqmAAQSQSENhG1ogAVvNFitzSckNIFIItZsalhdoQnoC7RREXcnob3p8np0IUhAekNoafkyoECQTBDXpdKGDDBddzhCi0Awk2aLTB0whM7hs0PtnmCAWi84AKIrFCRZ2lqs17qAzLbyhc2W8mAKoXAErNmhAlW9w1xbeG-PJ44bSfT2fVec4ReFg-3B2-YnkILzJBsY4nM+f67lggLXugQLOMB+pziO0F7AB9wYbGCavqmGwRNEsRxDC7DZHOaK-nsziRtGuGJjhJSXs45Dbq8lZWqkmwakIWoocIRr5nG8bZIaAmNGBYAMCU7bTCMcw4SJrxFl2d6VAAYs4D40nYIZ3LiMAAHoqEAA), which I think is a bit of an improvement to the end types being flat. ~It seems to work however there is...

In regards to the weird type error given, this is due to the looseness of the `RouteParams` type, with one of the union members being `ParameterValue`. When I remove that...

I managed to fix the failing test, however I'm not sure if it's a good solution that I did. Anyways, lemme know your thoughts, since I think I've addressed everything,...

@bakerkretzmar I just merged the branch into here, any extra thoughts on this?

@bakerkretzmar Howdy buddy, hope everything is okay. This has been sat for a while, I don't want to be annoying of course though

@bakerkretzmar No worries, I hope you had a nice time travelling. Did you get a chance to look around this?

That's okay buddy, Open Source can take time. Thank you for considering the work!

@bakerkretzmar that would be awesome, do you have any code to share? I'd be happy to open a PR if there is a base I can work from

I've opened a PR for this request #697