hpmvs icon indicating copy to clipboard operation
hpmvs copied to clipboard

Empty Octree cell?

Open pmoulon opened this issue 9 years ago • 6 comments

Hi @alexlocher, First of all congrats for the paper & for the code release. Reproducible research is a great thing!

I have compiled your project easily and ran it successfully and various tiny dataset.

On one dataset I obtain a strange result:

  • a "rectangular" hole (Like if an octree cell is never visited)
  • see the screenshot (lower left)

Did you already seen similar effect on some of your scene?

snapshot00 snapshot01 snapshot02

I will look to make more experiment on larger scenes and to load directly some OpenMVG scenes ;-)

pmoulon avatar Jun 23 '16 16:06 pmoulon

Hi @pmoulon ,

Thanks a lot for your comments and also trying out the code. Indeed I have noticed a similar situation on one of my datasets. I thought I fixed the bug, but apparently not ;) I'll investigate that more closely once I'm back from Vegas => in meantime you could try to set the additional command line parameter --subtrees=1 to skip splitting of the tree into subtrees. I'm interested if the problem is then still there...

Best Alex

alexlocher avatar Jun 25 '16 19:06 alexlocher

Hi @alexlocher Thank you for the tip.

I tried your additional command line parameter and it worked toto

BTW, it wrote the final point cloud but crash at the end

I0630 10:20:52.384783  8071 main.cpp:184] Done within 1787.94 seconds
*** Error in `./hpmvs': free(): invalid pointer: 0x00007fff7b467898 ***
Aborted

pmoulon avatar Jun 30 '16 08:06 pmoulon

Hi @pmoulon

I made an update in the codebase, which should fix the empty octree-cell, as well as the free() error. If you have a free second, could you quickly test it?

Thanks a lot!

alexlocher avatar Aug 04 '16 09:08 alexlocher

Thank you @alexlocher. I will try the fix in one or two weeks (I'm away from my computers for some days)

pmoulon avatar Aug 04 '16 09:08 pmoulon

Hi @alexlocher I made the test with an uptodate repository, and the problem is still here. image

The FREE error message do not longer appears ;-)

When I try the --subtrees=1 option, I was thinking that the process was blocked after this message:

I0820 18:33:10.064684 26061 main.cpp:171] prio 92 finished

but after some time, it displayed

W0820 18:40:24.785109 26068 PatchOptimizer.cpp:369] patch optimization failed: <nlopt roundoff-limited>

then .. took long time (still waiting...)

Any new idea?

pmoulon avatar Aug 20 '16 16:08 pmoulon

In order to obtain the full scene I sill have to use the --subtrees=1 option image

I0820 18:58:53.882977 26061 main.cpp:186] Done within 2340.82 seconds => --subtrees=1 I0820 18:27:28.634029 25954 main.cpp:186] Done within 601.522 seconds => normal settings

pmoulon avatar Aug 20 '16 17:08 pmoulon