NN-SVG icon indicating copy to clipboard operation
NN-SVG copied to clipboard

reduced dimension in hidden & input layer of FCN by 1.

Open tirtho109 opened this issue 10 months ago • 3 comments

Bias shouldn't be counted as layer dimension. So the dimension in the input and hidden layer needs to be reduced by 1 for FCNN.js

tirtho109 avatar Apr 19 '24 13:04 tirtho109

Hi @tirtho109 The layer dimension should be dependent on whether the user selects the "show bias units" checkbox. If I'm reading correctly, your PR always decrements the layer width by 1, but we shouldn't assume there's a bias unit unless the user presses the checkbox.

alexlenail avatar Apr 19 '24 13:04 alexlenail

Hi @alexlenail, Thanks for the feedback! Can you check one more time?

tirtho109 avatar Apr 19 '24 15:04 tirtho109

Why do you need a new state variable wasBiasShown when you already have showBias?

alexlenail avatar May 20 '24 19:05 alexlenail