NN-SVG icon indicating copy to clipboard operation
NN-SVG copied to clipboard

Height and width confusion in show dimensions text using AlexNet webGL

Open sumeyye-agac opened this issue 2 years ago • 2 comments

Tensor width and height order seems to to be incorrect. (For filter size dimensions, it is not wrong)

Screen Shot 2023-01-14 at 23 24 59

sumeyye-agac avatar Jan 14 '23 20:01 sumeyye-agac

@sumeyye-agac thanks for reporting this. Would changing the order of the help text (right underneath the word architecture be enough to fix this?

alexlenail avatar Jan 18 '23 17:01 alexlenail

Hi @alexlenail. The text underneath "Architecture" is correct, as you can see that a height of 50 and a width of 500 gives rectangles that are wider than they are tall, but the labels are simply misplaced. The 50 label should be put on the height, not the width. Fixed in PR #60.

jpauwels avatar Feb 11 '24 19:02 jpauwels