Alexander Larsson
Alexander Larsson
merging then
It feels a bit lame to read a byte at a time. Thats quite a lot of syscalls... Did you look at how this affects the time spent on authentication?...
The reading of one line a time will also cause the writing to the proxy client to be split up, so the performance is not just in the number of...
Some minor comments from me, but otherwise this looks good to me.
Well, one more comment: Maybe MAX_CLIENT_SERIAL can be made much much larger. We're only emitting "fake" requests at the beginning of the session when setting up the view of bus...
The proxy code relies on the serials to be monotonic, because we sometimes need to send our own messages from the proxy, and when we do this we bump last_serial...
A real fix for this would have to have a much more sophisticated tracking of which ids need to be rewritten and how much,
@zeenix You're not wrong, but what I mean is that we can't just delete this check. @matthiasclasen Yeah, that may work. It's equivalent to using the low bit for "fake"....
I think it is likely that any dbus library implementation would use some kind of at least semi-continuos serial counter, rather than completely random. If nothing else that is the...