Alex Lam S.L.

Results 141 comments of Alex Lam S.L.

Inconsistent behaviour in `vm.runInNewContext()`

Problem persists as of `v10.13.0`

Inconsistent behaviour with vm context of `Object.create(null)`

`0 & Object.create(null)` behaves consistently between `node` and `node-chakracore` (both at `8.11.1`) ``` $ nvs use node/8 PATH = node\8.11.1\x64 $ node > 0 & Object.create(null) TypeError: Cannot convert object...

Inconsistent behaviour with vm context of `Object.create(null)`

I want to be absolutely sure to avoid any `Object.prototype` properties leaking into the sandbox context, which is why it is coded this way. Having said that, I do understand...

Inconsistent behaviour with vm context of `Object.create(null)`

Thanks for the dicussion and clarifications - meanwhile I'll see if I can come up with an alternative test case in `uglify-js` which avoids this issue.

Inconsistent behaviour with vm context of `Object.create(null)`

Reverted the workaround in `uglify-js` to confirm the difference in behaviour between `node` and `node-chakracore` still persists as of `11.0.0-nightly20180522db93156017`

Inconsistent behaviour with vm context of `Object.create(null)`

Still an issue as of `v10.1.0`

Inconsistent behaviour with vm context of `Object.create(null)`

Reproducible in `v10.6.0`

vm.runInContext is not fully supported after upstream change

As @MSLaguana pointed out, #478 may be related. There is also #508.

vm.runInContext is not fully supported after upstream change

@MSLaguana thanks a lot for your fixes on issues related to `uglify-js` I shall keep a close eye on new releases of `node-chakracore` and report back.

vm.runInContext is not fully supported after upstream change

@MSLaguana using `11.0.0-nightly20180522db93156017`, #478 still fails. OT: so do #462 and #509