prealloc

prealloc copied to clipboard

Map preallocation

3

Preallocation of maps can be useful, as shown by PR #23, would be nice to have prealloc suggest that too. Just wondering how smart it can be made as things...

scop

Results from system in front of me: ``` BenchmarkMap/Size10NoPreallocate-4 1954923 603.7 ns/op 484 B/op 3 allocs/op BenchmarkMap/Size10Preallocate-4 2951250 393.8 ns/op 340 B/op 2 allocs/op BenchmarkMap/Size200NoPreallocate-4 71530 15337 ns/op 11270 B/op...

scop

line of sight loops trick prealloc

1

When ranging over a list that contains conditional `break`/`continue` directives and a `slice = append(slice, element)` at the end, `prealloc` suggests preallocation. [No lint triggered](https://play.golang.org/p/ybpu7Q8FIJ7) ```go var a []int for...

carnott-snap

Faulty prealloc

3

I currently work in a team and we had a code issue a few times that made it beyond code review. It is pre-allocating a slice with size instead of...

cbndr

Prealloc confused by variable redeclaration

1

In the following function, ```prealloc``` is confused by ```buf``` being redeclared: ``` func copySort(w io.Writer, r io.Reader, sep rune, keys []int) error { // Copy the header line. var buf...

dmoklaf

When the initial value is a pre-allocated slice, it should not be considered as a candidate for suggestion. So we try to recognize the `make` function and skip when the...

zlasd

If a pre-allocated slice is declared by `var` statement and explicit type, it would be incorrectly reported as a candidate for pre-allocation. For instance, the code snippet following would be...

zlasd

Example setup to reproduce the issue. **foo.txt** ```text some dummy text /* some comment */ more dummy text // some comment even more dummy text ``` **main.go** ```go type FooLine...

kellen-miller

Even with `simple=true`, the linter reports about preallocating slices. Here is one such example: ```go var ents []*Entity //

mholt

The `prealloc` code seems to assume that the length of whatever you are iterating over is known in advance. But this is no longer true with the new Go 1.23...

jdemeyer