wp-github-activity icon indicating copy to clipboard operation
wp-github-activity copied to clipboard

Published 20 hours ago • verified publisher icon alexkingorg

Incomplete github URLs

Open mattrude opened this issue 11 years ago • 5 comments

After activating the plugin, the github feed URL's are not fully qualified and are leading back to the hosting site.

Example: the main feed URL is listed as /<username> instead of https://github.com/<username> (see here for a live example), this seems to be true for all URL's created by this plugin.

Looking at the code around line 130 it looks like a java script is intended to update the URL's by adding https://github.com/ to the beginning, but this script does not seem to be updating the URL as intended.

mattrude avatar Jul 20 '13 18:07 mattrude

Probably needs to enqueue jQuery if it hasn't been. Want to submit a patch?

alexkingorg avatar Jul 20 '13 18:07 alexkingorg

The changes made in Pull Request #2 resolves this issue for me.

mattrude avatar Aug 14 '13 18:08 mattrude

Can we enqueue the script in cf_github_activity() (would be output in the footer) and still have it work? That way we don't enqueue jQuery on pages that don't need it.

alexkingorg avatar Aug 14 '13 21:08 alexkingorg

Sure, ill look into it.

mattrude avatar Aug 16 '13 14:08 mattrude

Have A look at Pull Request #2, I think it updated from my last change.

mattrude avatar Aug 18 '13 15:08 mattrude