Pytorch-Sketch-RNN icon indicating copy to clipboard operation
Pytorch-Sketch-RNN copied to clipboard

Version related, syntax and hyperparameter changes

Open varshaneya opened this issue 6 years ago • 0 comments

  1. Specifying dropout parameter to nn.LSTM with one layer will not apply dropout. You have to separately specify dropout using nn.Dropout and apply it to hidden since the paper talks only recurrent dropout and not input or output dropout.
  2. The original implementation calls for a 0.9 keep probability but yours calls for a 0.9 dropout probability. You need to change that in the class of Hyperparameters.
  3. F.softmax requires dimension parameter dim to be mentioned.
  4. Removed unnecessary t() and squeeze() operations and replaced them with view() directly.
  5. Missing closing parenthesis.
  6. For tensors with single data element in it, using square brackets with 0 will be considered as error from pytorch version 0.5 onwards. So replaced them with item().

varshaneya avatar Feb 02 '19 16:02 varshaneya