dynamics icon indicating copy to clipboard operation
dynamics copied to clipboard

Published 20 hours ago • verified publisher icon alexheretic

Make compatible with the module system

Open bowbahdoe opened this issue 2 years ago • 3 comments

If it isn't too much to ask - a module-info.java available would be nice. You can keep Java 8 compatibility by making a multi-release jar.

https://www.baeldung.com/maven-multi-release-jars

bowbahdoe avatar Oct 23 '22 13:10 bowbahdoe

I don't do much Java dev these days but I'm happy to accept PRs and get another release out.

alexheretic avatar Oct 23 '22 18:10 alexheretic

So there is a tiny smidge of an issue - you have one real dependency on one of your own libraries. The top level package in that is alexh. This also has a class in the alexh package.

Modules don't work with "split-packages".

I can make a PR with the changes required, but they would have to be breaking changes 🤷‍♂️ .

bowbahdoe avatar Oct 23 '22 23:10 bowbahdoe

Well, okay I think that might not be true - LiteJoiner just needs to move into the library and be required transitively so that it is the only holder of the alexh package. Would be weird to have LiteJoiner be in fluent though :man_shrugging:

Easiest answer, honestly, is to just not expose LiteJoiner.

bowbahdoe avatar Oct 26 '22 04:10 bowbahdoe