react-coding-challenges icon indicating copy to clipboard operation
react-coding-challenges copied to clipboard

Published 20 hours ago • verified publisher icon alexgurr

Fix the condition for rocket take off

Open gtanczyk opened this issue 2 years ago • 4 comments

It should start after 5 seconds, and do not come back.

gtanczyk avatar Apr 13 '22 11:04 gtanczyk

This looks like a solution to me (albeit not the correct one either). If i'm wrong, please add a comment explaining your fix.

alexgurr avatar Apr 14 '22 02:04 alexgurr

Currently the rocket starts immediately after page load, and comebacks after 5 seconds. My PR is not supposed to provide a solution to the coding task, but rather fix this little quirk. The solution to the coding task is elsewhere anyway.

gtanczyk avatar Apr 14 '22 05:04 gtanczyk

@alexgurr is the intention to expect the candidate to spot&fix this problem?

gtanczyk avatar Apr 14 '22 09:04 gtanczyk

Interesting, I've never spotted this. Let me verify the problem/fix. This is not part of the challenge :)

alexgurr avatar Apr 14 '22 09:04 alexgurr