aes_crypt icon indicating copy to clipboard operation
aes_crypt copied to clipboard

Moved to Null Safety

Open 3htsham opened this issue 3 years ago • 7 comments

Moved the project to null safety

3htsham avatar Jan 08 '22 08:01 3htsham

@3htsham thank you for this work, much appreciated!

longtimedeveloper avatar Feb 21 '22 21:02 longtimedeveloper

@3htsham I found one issue that is easy to correct.

From this file: aescrypt.dart

For this function: Future<String> decryptTextFromFile(String srcFilePath, {bool utf16 = false, Endian endian = Endian.big}) async {

Change this line: final Uint8List decData = await decryptDataFromFileSync(srcFilePath);

To: (changing the call to an async call instead of synchronous.) final Uint8List decData = await decryptDataFromFile(srcFilePath);

Best regards,

Karl

longtimedeveloper avatar Feb 21 '22 23:02 longtimedeveloper

The complaint of that "this package isn't null safe still persists", even if this package is used.

PeterAkande avatar Feb 25 '22 01:02 PeterAkande

@PeterAkande I'm using this pull request with my above change, works great. Granted there are a few corrections you may need to make to get the code super clean, but I've got it running great.

longtimedeveloper avatar Feb 25 '22 01:02 longtimedeveloper

Okay, Thanks.

PeterAkande avatar Feb 25 '22 02:02 PeterAkande

@PeterAkande Forgot to mention. I used GitHub Desktop to check out this pull request. This tool makes it a breeze to check out a pull request that has not yet been merged.

longtimedeveloper avatar Feb 25 '22 03:02 longtimedeveloper

@longtimedeveloper Hello, so your branch is ready to be used?

There is also this package: https://pub.dev/packages/aes_crypt_null_safe

busslina avatar Sep 19 '23 23:09 busslina