Alex Garel

Results 244 comments of Alex Garel

It's very strange when you know that your example device_id does not even appear in the annotation_vote database ! I tested in production, and for me using the subquery I ...

It's sure that the obsolete products are still in the JSONL product dump? No they are not (yet). That said @stephanegigandet thinks obsolete products are less than 5 000 so...

Yes I think it's ok to add it for github actions.

Proposed patch ``` patch diff --git a/pyPdf/pdf.py b/pyPdf/pdf.py index bf60d01..586ea81 100644 --- a/pyPdf/pdf.py +++ b/pyPdf/pdf.py @@ -701,7 +701,7 @@ class PdfFileReader(object): # start at the end: stream.seek(-1, 2) line =...

Hum a better patch: ``` diff --- a/pyPdf/pdf.py +++ b/pyPdf/pdf.py @@ -701,7 +701,7 @@ class PdfFileReader(object): # start at the end: stream.seek(-1, 2) line = '' - while not line:...

sorry, corrected :-)

I updated tests results.

@bazylevnik0 thanks for this great contribution. Sorry for we were quite under an heavy load last week, and it's only now that I saw it was failing since a long...

@stephanegigandet we still need a deploy on pro platform to fix this !