SmallerC icon indicating copy to clipboard operation
SmallerC copied to clipboard

Warns

Open stsp opened this issue 1 year ago • 5 comments

Warning fixes that are still relevant.

stsp avatar Apr 13 '24 08:04 stsp

You applied the smlrl fixes but smlrc still gives warnings. Interestingly smlrcc no longer gives warnings, even though no fixes were applied there. I guess gcc improved its detection logic.

stsp avatar Apr 13 '24 08:04 stsp

I didn't do anything about these because my version of gcc doesn't warn here (yet). Fixing warnings in the dark is kinda silly, especially so if I need a fix different from the proposed.

In smlrcc I did cap the file name length (arbitrarily at 255 chars) and that was enough for gcc to see name length + file length fit into 10 decimal digits (the file length had already been capped). There was also some fixing around realloc() in fatargs(), which is used in smlrl, smlrcc, smlrpp, but those are probably unrelated.

alexfru avatar Apr 13 '24 15:04 alexfru

Fixing warnings in the dark is kinda silly, especially so if I need a fix different from the proposed.

So why not to apply my patch then? :)

In smlrcc I did cap the file name length (arbitrarily at 255 chars)

Ah, good to know. I was wondering where those warning went.

stsp avatar Apr 13 '24 16:04 stsp

Fixing warnings in the dark is kinda silly, especially so if I need a fix different from the proposed.

So why not to apply my patch then? :)

I wouldn't know if it was fixed and gone.

alexfru avatar Apr 13 '24 17:04 alexfru

Don't you believe me that they are gone? The remained patches are trivial.

stsp avatar Apr 13 '24 19:04 stsp