Alex Forster comments

Results 20 comments of


                                            Alex Forster

Configure CI to build on multiple architectures, glibc and musl, default features and novendor & add release workflow

Taking a quick skim, this looks awesome – thanks! I'll try to review it over the weekend.

Configure CI to build on multiple architectures, glibc and musl, default features and novendor & add release workflow

Cool, the tests worked. Note that [this](https://github.com/jirutka/setup-alpine/blob/c804535fc7a018d1acc4c4a123a8ced833b37f72/setup-alpine.sh#L327) is giving a [deprecation warning](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/). Now let's see if deploying works...

Configure CI to build on multiple architectures, glibc and musl, default features and novendor & add release workflow

Neat, publishing works too! Thanks for this, I appreciate it.

Will you consider supporting it on Android?

Hi – sounds fine theoretically, but I don't know anything about Android development. Does it mean adding lots of Android-specific build system stuff?

Implement methods on `Registry` for managing prefix and common labels

> I think we'd need a bit more context behind this. Right, I think based on your feedback that I wasn't clear on the use-case. Specifically, this is intended to...

Implement methods on `Registry` for managing prefix and common labels

I've rebased and added a `Signed-off-by`

Add a setter for `header_table_size`

@seanmonstar Is there anything I can do to help this get merged?

Allow enabling specific cfg option

I run macOS but write code exclusively for other platforms/architectures, and I really really wish I didn't have to hardcode the build target in `.cargo/config.toml` just to make the IDE...

32 bit build broken?

There's no way to fixup the bindings right now. See these for more background (same underlying issue)... * https://github.com/libbpf/libbpf-sys/issues/27 * https://github.com/libbpf/libbpf-sys/issues/33 I prefer to continue generating bindings ahead-of-time, rather than...

await content.read() reads partial content under high load

I'm seeing this as well. I'm dealing with a ~20mbit/sec data stream, and if I don't read quickly enough, the library appears to just silently drop chunks of payload.