MassTransit.EventStoreIntegration icon indicating copy to clipboard operation
MassTransit.EventStoreIntegration copied to clipboard

System.TypeLoadException: Method 'SendQuery' in type 'MassTransit.EventStoreIntegration.Saga.EventStoreSagaRepository`1' from assembly 'MassTransit.EventStoreIntegration, Version=6.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.

Open PatriceMarin opened this issue 4 years ago • 7 comments

Hi Alexey,

I'm working on a project which required saga features. The Sample-Courier provided by MassTransit describes everything I need, except the storing part.

So I'm writing a POC to be more familiar with Routing Slip pattern and so on...based on Sample-Courier and your MassTransit.EventStoreIntegration to store the saga state in EventStore.

When I start the SagaStateMachine host, I've got the following error: "System.TypeLoadException: Method 'SendQuery' in type 'MassTransit.EventStoreIntegration.Saga.EventStoreSagaRepository`1' from assembly 'MassTransit.EventStoreIntegration, Version=6.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation."

I noticed the Task SendQuery<T> method throw: NotImplementedByDesignException("Redis saga repository does not support queries");

Can you explain me why this method is not implemented?

I hope it's clear enough...

Thanks for your help.

PatriceMarin avatar Mar 13 '20 10:03 PatriceMarin

Hi,

It seems the new version of MassTransit has some breaking changes on the ISagaRepository<TSaga> interface.

PatriceMarin avatar Mar 13 '20 10:03 PatriceMarin

It's because EventStore doesn't have queries. It is the same for all persistence providers that can only fetch entities by key, like Redis: https://masstransit-project.com/usage/sagas/redis.html

alexeyzimarev avatar Mar 13 '20 11:03 alexeyzimarev

The reason I got this exception is MassTransit.EventstoreIntegration is not compatible with the latest version of MassTransit (v6.2.0).

MassTransit has updated the signature of the SendQuery<T> method of the ISagaRepository<TSaga> interface.

I've made the changes locally and I'm now able to run the host.

Do you think you will be able to apply the changes? Otherwise, I could contribute to the project via a PR?

Just let me know.

Thanks

PatriceMarin avatar Mar 13 '20 14:03 PatriceMarin

a PR would be great :)

alexeyzimarev avatar Mar 13 '20 15:03 alexeyzimarev

I do not have permissions to push my branch on the repository.

PatriceMarin avatar Mar 13 '20 18:03 PatriceMarin

PRa are done from personal forks. Check the GH docs.

On Fri, 13 Mar 2020 at 19:20, Patrice Marin [email protected] wrote:

I do not have permissions to push my branch on the repository.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/alexeyzimarev/MassTransit.EventStoreIntegration/issues/7#issuecomment-598853960, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVQYVICUCOYJI46WUG7WYLRHJ2ORANCNFSM4LG7OH3A .

alexeyzimarev avatar Mar 13 '20 19:03 alexeyzimarev

Hi Alexey, My PR does not build. It seems the final step, unit tests, failed after 6 hours. I don't know why. I've run the tests on my laptop....everything works fine.

Any clue?

PatriceMarin avatar Mar 16 '20 10:03 PatriceMarin