picocolors icon indicating copy to clipboard operation
picocolors copied to clipboard

Update README.md

Open r-rajaneesh opened this issue 3 years ago • 5 comments

actually 6KB not 8KB image

r-rajaneesh avatar Sep 27 '21 16:09 r-rajaneesh

Thanks for the PR. I hope the library can stick to the target. I'll be adding minimum browser support as a part of v0.1 so the final size may vary. I've been using data from packagephobia.com and npmjs.com, not sure though how different their approaches are in calculating size.

But if we stick to the target after the release, we'll be able to confidently merge your PR :)

alexeyraspopov avatar Sep 27 '21 16:09 alexeyraspopov

Thanks for the PR. I hope the library can stick to the target. I'll be adding minimum browser support as a part of v0.1 so the final size may vary. I've been using data from packagephobia.com and npmjs.com, not sure though how different their approaches are in calculating size.

But if we stick to the target after the release, we'll be able to confidently merge your PR :)

cool 👍

r-rajaneesh avatar Sep 27 '21 17:09 r-rajaneesh

@alexeyraspopov there is something fishy image

r-rajaneesh avatar Oct 09 '21 03:10 r-rajaneesh

@Nigelrex I don't know what github extension you are using, but if that is repository size, then that is just because it includes things like benchmarks and tests. You can look at Packagephobia for the actually NPM package size.

AsyncBanana avatar Oct 09 '21 15:10 AsyncBanana

It does seem like the extension is calculating the repo size. We didn't have much stuff initially, so the repo size was matching NPM package size. Now that we got docs, tests, benchmarks, these numbers drift apart but the end users are not affected by this.

alexeyraspopov avatar Oct 11 '21 14:10 alexeyraspopov