minio-kv icon indicating copy to clipboard operation
minio-kv copied to clipboard

Add k8s Deployment and Service

Open olgierdg opened this issue 4 years ago • 4 comments

Simple Kubernetes Deployment and Service specs for your app. The Deployment basically follows the docker run command from the Testing section of the README. It could be improved by taking those 2 env variables from a Secret object instead of having them in the Deployment itself, I can do that as well.

Unfortunately I have not been able to test it properly due to app errors, but at least the output is consistent between simple docker run and running it on k8s:

minio-k8s-screenshot

Perhaps you could help me out a bit with testing it?

olgierdg avatar Oct 12 '19 17:10 olgierdg

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

derek[bot] avatar Oct 12 '19 17:10 derek[bot]

/msg: slack

alexellis avatar Oct 13 '19 08:10 alexellis

-- Join Slack to connect with the community using the #general channel within the OpenFaaS Slack workspace. https://docs.openfaas.com/community

derek[bot] avatar Oct 13 '19 08:10 derek[bot]

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

derek[bot] avatar Oct 13 '19 10:10 derek[bot]