minio-kv icon indicating copy to clipboard operation
minio-kv copied to clipboard

Optional read secret from mount path

Open aidun opened this issue 4 years ago • 4 comments

This PR implements the changes of #3

MINIO_SECRET_KEY is the default Source of the Secret. If MINIO_SECRET_KEY_MOUNT_PATH is present, minio-kv try to read the secret from the file provided in MINIO_SECRET_KEY_MOUNT_PATH. If there is any error, the fallback is MINIO_SECRET_KEY.

Starting Minio: Bildschirmfoto 2019-10-13 um 12 01 44

Building + Starting minio-kv: Bildschirmfoto 2019-10-13 um 12 03 24

Testing: Bildschirmfoto 2019-10-13 um 12 03 34

aidun avatar Oct 12 '19 11:10 aidun

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

derek[bot] avatar Oct 12 '19 11:10 derek[bot]

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

derek[bot] avatar Oct 13 '19 09:10 derek[bot]

I think there should be an input validation for the other environments to.

aidun avatar Oct 13 '19 10:10 aidun

@alexellis is the implementation the way you want it?

aidun avatar Oct 14 '19 16:10 aidun