k3sup
k3sup copied to clipboard
alexellis
Exclude windows compilation from all target on non x86_64
Description
Exclude windows compilation from all target on non x86_64
Motivation and Context
golang does not support windows on non x86_64 architectures which makes make all fail on e.g. aarch64
How Has This Been Tested?
I have compiled k3sup on x86_64 and aarch64.
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I've read the CONTRIBUTION guide
- [x] I have signed-off my commits with
git commit -s - [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
Thanks for the contribution.
Can you tell me the story behind why you are building k3sup instead of using the binary?
golang does not support windows on non x86_64 architectures which makes make all fail on e.g. aarch64
Does that include Apple M1? I was fairly sure I created x86 Windows binaries for other projects there, but I could be imagining it.
Thanks for the contribution.
Can you tell me the story behind why you are building k3sup instead of using the binary?
I am testing a multi-arch container for golang and am testing whether it can build popular golang applications.
golang does not support windows on non x86_64 architectures which makes make all fail on e.g. aarch64
Does that include Apple M1? I was fairly sure I created x86 Windows binaries for other projects there, but I could be imagining it.
I don't know to be frankly honest, as I don't own a Apple M1. I have run the build on a Cavium Thunder X2.
Hi, I'm glad that you enjoy K3sup.
This is not something that I need at this time, but if you'd like to sponsor me on GitHub, then I'd merge it and maintain it.
Alex