arkade icon indicating copy to clipboard operation
arkade copied to clipboard

Feature request: add `rpk` to `arkade get`

Open vuldin opened this issue 3 years ago • 3 comments

The Redpanda Keeper (rpk) is Redpanda's CLI utility. rpk commands allow you to configure and manage Redpanda clusters, tune them for better performance, manage topics and groups, manage access control lists (ACLs), and more.

Expected Behaviour

Future example output:

> arkade get rpk
Downloading: rpk
Downloading: https://github.com/redpanda-data/redpanda/releases/download/v22.1.1/rpk-linux-amd64.zip
12.4 MiB / 12.4 MiB [----------------------------------------------------------------------] 100.00%
/tmp/rpk-linux-amd64.zip written.
/tmp/rpk rpk
2022/01/19 12:06:22 unzipped archive into /tmp: 1 files, 0 dirs (487.370723ms)
2022/01/19 12:06:22 Unzipped: /tmp/rpk
2022/01/19 12:06:22 Copying /tmp/rpk to /home/user/.arkade/bin/rpk

Tool written to: /home/user/.arkade/bin/rpk

# Add arkade binary directory to your PATH variable
export PATH=$PATH:$HOME/.arkade/bin/

# Test the binary:
/home/user/.arkade/bin/rpk

# Or install with:
sudo mv /home/user/.arkade/bin/rpk /usr/local/bin/

Are you a GitHub Sponsor yet (Yes/No?)

  • [ ] Yes
  • [x] No

I haven't looked into this yet, but I'll start the conversation with my colleagues and broader org.

Context

If requesting a CLI for "arkade get"

How many downloads does this tool have? ~205K

If rpk is approved then we myself or someone else from Redpanda would create the PR for adding it to the tool. One reason why I'm hoping to get rpk added is because I use this tool all the time, and I know it would simplify our documentation at https://docs.redpanda.com/. Once added, I can then more easily bring in the doc team and show them how arkade commands can replace more complicated steps (installing our CLI, cert-manager, etc.) throughout our site.

Your Environment

The goal would be to ark get rpk on the following platforms (Windows not yet supported):

darwin-amd64
darwin-arm64
linux-amd64
darwin-arm64

Not sure the below details are too relevant, since this is just my local laptop.

  • What Kubernetes distribution are you using?
> kubectl version
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-25T21:25:17Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-25T21:19:12Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"linux/amd64"}
  • Operating System and version (e.g. Linux, Windows, MacOS):
> uname -a                 
Linux laptop 5.15.0-27-generic #28-Ubuntu SMP Thu Apr 14 04:55:28 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
> cat /etc/os-release  
PRETTY_NAME="Ubuntu 22.04 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04 (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy
  • What arkade version is this?
> arkade version                      
            _             _      
  __ _ _ __| | ____ _  __| | ___ 
 / _` | '__| |/ / _` |/ _` |/ _ \
| (_| | |  |   < (_| | (_| |  __/
 \__,_|_|  |_|\_\__,_|\__,_|\___|

Open Source Marketplace For Developer Tools

Version: 0.8.23
Git Commit: be5a8cc594cbe860055ede8ec36635fcf36ae283

 🐳 arkade needs your support, learn more: https://my.arkade.dev

vuldin avatar May 03 '22 13:05 vuldin

Hi @vuldin please feel free to contribute this via a PR.

I'd suggest looking at a closed / merged PR to see how we tend to do this and what's involved.

GitHub Sponsorships are also appreciated from the community, at whatever tier and it'll show up on the repo when you comment in the future too.

Alex

alexellis avatar May 03 '22 19:05 alexellis

Awesome thanks!

vuldin avatar May 03 '22 20:05 vuldin

@vuldin when you have a PR ready, please link it to this issue with

Closes: #...

alexellis avatar May 14 '22 07:05 alexellis

Hi @vuldin would you like us to close this issue, or are you still planning on working on it?

You can take a look at #731 for an example of what a PR should look like.

alexellis avatar Aug 11 '22 18:08 alexellis