arkade icon indicating copy to clipboard operation
arkade copied to clipboard

Adding operator-sdk to list of tools

Open xshyamx opened this issue 3 years ago • 3 comments

Signed-off-by: S. Shyam Sundar

Description

Adding new tool operator-sdk to arkade

Motivation and Context

  • [x] I have raised an issue #547 to propose this change (required)

How Has This Been Tested?

Added unit tests & tested locally on mac & ubuntu systems

$ arkade get operator-sdk --os linux --arch x86_64
Downloading: operator-sdk
Downloading: https://github.com/operator-framework/operator-sdk/releases/download/v1.13.1/operator-sdk_linux_amd64
/tmp/operator-sdk_linux_amd64 written.

Tool written to: /home/ubuntu/.arkade/bin/operator-sdk

# Add arkade binary directory to your PATH variable
export PATH=$PATH:$HOME/.arkade/bin/

# Test the binary:
/home/ubuntu/.arkade/bin/operator-sdk

# Or install with:
sudo mv /home/ubuntu/.arkade/bin/operator-sdk /usr/local/bin/
$ file $HOME/.arkade/bin/operator-sdk
/home/ubuntu/.arkade/bin/operator-sdk: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=iOK5E0ik7P6nOLPpeaSh/pifaHRE9uYlgFn46693d/t_PDEsRH4D3d0ljPPSV1/nDglUP5WQiSCoHAWwoN4, not stripped
$ arkade get operator-sdk --os linux --arch aarch64
Downloading: operator-sdk
Downloading: https://github.com/operator-framework/operator-sdk/releases/download/v1.13.1/operator-sdk_linux_arm64
/tmp/operator-sdk_linux_arm64 written.

Tool written to: /home/ubuntu/.arkade/bin/operator-sdk

# Add arkade binary directory to your PATH variable
export PATH=$PATH:$HOME/.arkade/bin/

# Test the binary:
/home/ubuntu/.arkade/bin/operator-sdk

# Or install with:
sudo mv /home/ubuntu/.arkade/bin/operator-sdk /usr/local/bin/
$ file $HOME/.arkade/bin/operator-sdk
/home/ubuntu/.arkade/bin/operator-sdk: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=yveh1SU2U8I-pPXToh9h/TCCaNdGei_qekJmBQ1mT/k8CuatCEMBbjCEjUePKU/LE4WMxQh0bG99dsT0_YL, not stripped
$ arkade get operator-sdk --os darwin --arch x86_64
Downloading: operator-sdk
Downloading: https://github.com/operator-framework/operator-sdk/releases/download/v1.13.1/operator-sdk_darwin_amd64
/tmp/operator-sdk_darwin_amd64 written.

Tool written to: /home/ubuntu/.arkade/bin/operator-sdk

# Add arkade binary directory to your PATH variable
export PATH=$PATH:$HOME/.arkade/bin/

# Test the binary:
/home/ubuntu/.arkade/bin/operator-sdk

# Or install with:
sudo mv /home/ubuntu/.arkade/bin/operator-sdk /usr/local/bin/
$ file $HOME/.arkade/bin/operator-sdk
/home/ubuntu/.arkade/bin/operator-sdk: Mach-O 64-bit x86_64 executable

Are you a GitHub Sponsor (Yes/No?)

  • [ ] Yes
  • [x] No

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • [x] I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
  • [ ] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I've read the CONTRIBUTION guide
  • [x] I have signed-off my commits with git commit -s
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.
  • [ ] I have tested this on arm, or have added code to prevent deployment

xshyamx avatar Oct 20 '21 21:10 xshyamx

Thanks for the pointer. I've pushed with the requested changes

xshyamx avatar Oct 21 '21 07:10 xshyamx

For this section, I'd like to see more specifics:

How Has This Been Tested?

Please show us the download working for various OS/arch combinations using the new --os and --arch flags including verifying the result using the file utility.

i.e.

arkade get faas-cli --os linux --arch arm64
file $HOME/.arkade/bin/faas-cli

file /home/alex/.arkade/bin/faas-cli
/home/alex/.arkade/bin/faas-cli: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=_D-EpIT8h52TFhJislty/ihH2PleK3fNR46HTjZy7/yYWV02V8ov99nubz5mq6/NWPCSooJDW0HWapX17X_, stripped

alexellis avatar Oct 22 '21 09:10 alexellis

Updated PR with tests as requested

xshyamx avatar Oct 24 '21 18:10 xshyamx