*scs.sessionResponseWriter does not implement http.Hijacker

[NewHouses]

Hey there! 👋 It seems like we've hit a small roadblock with the scs.sessionResponseWriter wrapper for http.response. Currently, it doesn't implement the http.Hijacker interface. So, when attempting to open a WebSocket, you might encounter the error message: websocket: response does not implement http.Hijacker.

In the past, it were using *scs.bufferedResponseWriter, which conveniently does implement the Hijacker interface.

[wosienko]

@alexedwards would you kindly accept pull request with a fix to this error?

[alexedwards]

I think that the correct fix here is really for the websocket library to start supporting http.ResponseController, which is the modern way of dealing with this.

I've pushed https://github.com/alexedwards/scs/commit/a38e822451b69071afa6fd12667d50df4563d20f which makes sessionResponseWriter implement the Hijacker and Flusher interfaces for Go 1.20+. Please let me know if it solves your problem.

[wosienko]

Thank you, works like a charm!