Alex Edwards
Alex Edwards
@squiidz Yep, I'm happy to submit a PR for this. I'm not sure I agree on the blank response body though. I think that default behavior should be useful, and...
PR submitted.
I've just pushed commit https://github.com/alexedwards/scs/commit/62e546ce9d2d95a370da0629bd877d9e0c4ed9a0 which changes the way that LoadAndSave() works so that the response is no longer buffered. Combined with the new Go 1.20 http.ResponseController, this means that...
@ctian1 @theadell Flushing responses now seems to work great with SCS when you use the Go 1.20 `http.ResponseController` type to manage the flushing. Any session cookie is written with the...
@theadell Does it work if you use the tip version of SCS? `$ go get github.com/alexedwards/scs/v2@a803960`
I've released a new major version v2.6.0 which includes https://github.com/alexedwards/scs/commit/62e546ce9d2d95a370da0629bd877d9e0c4ed9a0 now :+1: I believe that this issue can now be closed, but if there continue to be any problems please...
@verygoodsoftwarenotvirus I think my comment in https://github.com/alexedwards/scs/issues/141#issuecomment-1774050802 applies here. I think the onus is really on the `sse` package to start supporting `http.ResponseController`. That it doesn't is a wider issue...
I don't want to take this forward at the moment. I'm going to close this issue.
Closing due to lack of response.
@lpic10 Good change, thanks!