LightningFlowComponents icon indicating copy to clipboard operation
LightningFlowComponents copied to clipboard

Datatable Property modified from your package, unable to restore your old version without my modification

Open idrissbe5 opened this issue 1 year ago • 3 comments

Hello there,

I work with your Datatable package, before your last update I added myself a property on the datatable.js to add a filter behaviour on the datatable.

But now I want to deploy your new version on my orgs but it keeps telling me that it's impossible because your version lacks my modification.

I want to erase my modification so I can deploy yours, but when I deploy I get this error : force-app/main/default/lwc/datatable/datatable.js lwc/datatable/datatable.js-meta.xml: You can’t remove the following public properties: showFilter,cb_showFilter, because the component is part of a managed package.

I can't just delete the datatable composant from my org to reinstall it because it's too referenced to be done.

I need a way to restore the old version or to deploy your new one without getting an error. @ericrsmith35

idrissbe5 avatar Sep 15 '23 15:09 idrissbe5

The best way to do this will be to copy the current source code, make your changes, then deploy the code directly from VSCode

On Fri, Sep 15, 2023 at 8:38 AM idrissbe5 @.***> wrote:

Hello there,

I work with your Datatable package, before your last update I added myself a property on the datatable.js to add a filter behaviour on the datatable.

But now I want to deploy your new version on my orgs but it keeps telling me that it's impossible because your version lacks my modification.

I want to erase my modification so I can deploy yours, but when I deploy I get this error : force-app/main/default/lwc/datatable/datatable.js lwc/datatable/datatable.js-meta.xml: You can’t remove the following public properties: showFilter,cb_showFilter, because the component is part of a managed package.

I can't just delete the datatable composant from my org to reinstall it because it's too referenced to be done.

I need a way to restore the old version or to deploy your new one without getting an error. @ericrsmith35 https://github.com/ericrsmith35

— Reply to this email directly, view it on GitHub https://github.com/alexed1/LightningFlowComponents/issues/1457, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF4UHX75NM3E6PKORQIHOD3X2RZBBANCNFSM6AAAAAA4Z7ZHDE . You are receiving this because you were mentioned.Message ID: @.***>

ericrsmith35 avatar Sep 15 '23 16:09 ericrsmith35

Hello,

I thought about this but it implies that I retrieve on VSCode all your modifications and all the files. Because I only retrieved for my development the datatable and the ersDatatableCPE LWC.

It means also that I will have to do this for all your updates.

Is it still the best way ? And easiest ?

Thank you again


De : Eric Smith @.> Envoyé : vendredi 15 septembre 2023 18:36 À : alexed1/LightningFlowComponents @.> Cc : BELAID Idriss @.>; Author @.> Objet : Re: [alexed1/LightningFlowComponents] Datatable Property modified from your package, unable to restore your old version without my modification (Issue #1457)

The best way to do this will be to copy the current source code, make your changes, then deploy the code directly from VSCode

On Fri, Sep 15, 2023 at 8:38 AM idrissbe5 @.***> wrote:

Hello there,

I work with your Datatable package, before your last update I added myself a property on the datatable.js to add a filter behaviour on the datatable.

But now I want to deploy your new version on my orgs but it keeps telling me that it's impossible because your version lacks my modification.

I want to erase my modification so I can deploy yours, but when I deploy I get this error : force-app/main/default/lwc/datatable/datatable.js lwc/datatable/datatable.js-meta.xml: You can’t remove the following public properties: showFilter,cb_showFilter, because the component is part of a managed package.

I can't just delete the datatable composant from my org to reinstall it because it's too referenced to be done.

I need a way to restore the old version or to deploy your new one without getting an error. @ericrsmith35 https://github.com/ericrsmith35

— Reply to this email directly, view it on GitHub https://github.com/alexed1/LightningFlowComponents/issues/1457, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF4UHX75NM3E6PKORQIHOD3X2RZBBANCNFSM6AAAAAA4Z7ZHDE . You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHubhttps://github.com/alexed1/LightningFlowComponents/issues/1457#issuecomment-1721557968, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5YY2SBME5WPRSNCQCI5RF3X2R7ZXANCNFSM6AAAAAA4Z7ZHDE. You are receiving this because you authored the thread.Message ID: @.***>

idrissbe5 avatar Sep 18 '23 07:09 idrissbe5

That would be the only way once you add a new public attribute. They cannot be removed while existing flows are using the modified component.

On Mon, Sep 18, 2023 at 3:31 AM idrissbe5 @.***> wrote:

Hello,

I thought about this but it implies that I retrieve on VSCode all your modifications and all the files. Because I only retrieved for my development the datatable and the ersDatatableCPE LWC.

It means also that I will have to do this for all your updates.

Is it still the best way ? And easiest ?

Thank you again


De : Eric Smith @.> Envoyé : vendredi 15 septembre 2023 18:36 À : alexed1/LightningFlowComponents @.> Cc : BELAID Idriss @.>; Author @.> Objet : Re: [alexed1/LightningFlowComponents] Datatable Property modified from your package, unable to restore your old version without my modification (Issue #1457)

The best way to do this will be to copy the current source code, make your changes, then deploy the code directly from VSCode

On Fri, Sep 15, 2023 at 8:38 AM idrissbe5 @.***> wrote:

Hello there,

I work with your Datatable package, before your last update I added myself a property on the datatable.js to add a filter behaviour on the datatable.

But now I want to deploy your new version on my orgs but it keeps telling me that it's impossible because your version lacks my modification.

I want to erase my modification so I can deploy yours, but when I deploy I get this error : force-app/main/default/lwc/datatable/datatable.js lwc/datatable/datatable.js-meta.xml: You can’t remove the following public properties: showFilter,cb_showFilter, because the component is part of a managed package.

I can't just delete the datatable composant from my org to reinstall it because it's too referenced to be done.

I need a way to restore the old version or to deploy your new one without getting an error. @ericrsmith35 https://github.com/ericrsmith35

— Reply to this email directly, view it on GitHub https://github.com/alexed1/LightningFlowComponents/issues/1457, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AF4UHX75NM3E6PKORQIHOD3X2RZBBANCNFSM6AAAAAA4Z7ZHDE>

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub< https://github.com/alexed1/LightningFlowComponents/issues/1457#issuecomment-1721557968>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/A5YY2SBME5WPRSNCQCI5RF3X2R7ZXANCNFSM6AAAAAA4Z7ZHDE>.

You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/alexed1/LightningFlowComponents/issues/1457#issuecomment-1722884511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF4UHX65RPOBLTE4WMWFZNTX272GBANCNFSM6AAAAAA4Z7ZHDE . You are receiving this because you were mentioned.Message ID: @.***>

ericrsmith35 avatar Sep 18 '23 12:09 ericrsmith35