timetwister icon indicating copy to clipboard operation
timetwister copied to clipboard

Published 20 hours ago • verified publisher icon alexduryee

Add support for Russian and Portuguese

Open JessRudder opened this issue 8 years ago • 4 comments

JessRudder avatar Jan 24 '17 00:01 JessRudder

Coverage Status

Coverage remained the same at 96.505% when pulling a2c6c90a2749d88b6b22bc42091bf73b788c28fc on JessRudder:add-language-support into c9c0ab97b8fd3535322e3ced5a14e97a5de84e2a on alexduryee:master.

coveralls avatar Jan 24 '17 00:01 coveralls

Thanks for this! I'd like to have specs for each language supported by the library - could you add Portuguese and Russian dates to https://github.com/alexduryee/timetwister/blob/master/spec/dates_spec.rb#L620 ?

I realize now that August is a bad month to use for testing languages, since agosto appears in multiple languages. It's not necessary, but if you could change the month in the language test from August to anything else, I'd be eternally grateful.

alexduryee avatar Jan 24 '17 18:01 alexduryee

@alexduryee absolutely! It'll be a few days before I can get to that (most likely). Will it work if I provide the tests by the end of this week?

JessRudder avatar Jan 24 '17 18:01 JessRudder

@JessRudder Sure thing! Take your time; there's no rush, and I need to diagnose an issue on my end anyway.

Thanks so much for working on this; it's tremendously appreciated!

alexduryee avatar Jan 24 '17 21:01 alexduryee