gnome-github-notifications icon indicating copy to clipboard operation
gnome-github-notifications copied to clipboard

Published 20 hours ago • verified publisher icon alexduf

Gnome 43 and 44 support

Open Lyr-7D1h opened this issue 1 year ago • 7 comments

Hi, this PR includes the changes needed to make this extension fully compatible with Gnome 43 and 44.

This pr includes:

  • Changes needed for gnome 43 and 44
  • Check for gnome version on each change
  • Formatting changes
  • Prettier settings

At the moment I can only confirm that this is fully working on Gnome 44 as this is my current working environment. This would fix #54 #51

Lyr-7D1h avatar Jul 14 '23 23:07 Lyr-7D1h

I tried to contact @alexduf without luck. I'm waiting approval from extensions team. I changed the last commit for this one https://github.com/Shelvak/gnome-github-notifications/commit/ae915ac2a74b67f79e3c42e91f5e1de8ad987c60 because I couldn't get the click open the link =(

Great work! If I get approval from gnome team, we can keep pushing improvements :rocket: I'll keep it posted here

Shelvak avatar Jul 26 '23 18:07 Shelvak

Thank you @Lyr-7D1h, for your contribution. I installed your version manually using Git. That works great for me.

BRAVO68WEB avatar Aug 24 '23 05:08 BRAVO68WEB

idem I installed it manually, thanks a lot

alice-telescoop avatar Oct 11 '23 15:10 alice-telescoop

Thanks for posting this. I'm using it on Ubuntu 23.04 (Gnome 44.3).

petertgiles avatar Oct 30 '23 12:10 petertgiles

Thank you, this had been working great for me in 44. 45 has unfortunately broken it.

SyntaxError: import declarations may only appear at top level of a module

Stack trace:
  @file:///home/gary/.local/share/gnome-shell/extensions/[email protected]/prefs.js:3:24
  _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

GaryElshaw avatar Nov 07 '23 22:11 GaryElshaw