curl-rust icon indicating copy to clipboard operation
curl-rust copied to clipboard

Published 20 hours ago • verified publisher icon alexcrichton

use vcpkg only for `*-msvc` targets

Open ognevny opened this issue 1 year ago • 3 comments

for other windows targets (*-gnu and *-gnullvm) pkg-config is usually used

ognevny avatar Mar 26 '24 11:03 ognevny

I've rebased branch and simplified patch a bit @alexcrichton can this be merged? I see other -sys crates use vcpkg for MSVC only

ognevny avatar Nov 27 '24 04:11 ognevny

I'm sorry but I don't personally have the energy to shepherd this. Changes like this unfortunately have a pretty high likelihood of causing breakage for users. That breakage typically requires follow-ups from the maintainership side here which I don't have a ton of time for nowadays. If someone else wants to champion this though and field requests though that's ok too! (they'll need to merge though)

alexcrichton avatar Dec 03 '24 17:12 alexcrichton

we can change it to run both vcpkg and pkg-config on windows-gnu. it shouldn't break "pure" msys2 environments (like CIs)

ognevny avatar Dec 03 '24 17:12 ognevny

@alexcrichton can you give this or #623 a try, please? I've got errors when linking curl-sys built library into a cargo with Rust 1.91.0: https://github.com/msys2/MINGW-packages/pull/26143#issuecomment-3457638852, so having an option to link system library is best for us

ognevny avatar Oct 29 '25 13:10 ognevny