git-blame icon indicating copy to clipboard operation
git-blame copied to clipboard

Published 20 hours ago • verified publisher icon alexcorre

Blame doesnt update real time when editing with gutter open

Open alexcorre opened this issue 11 years ago • 6 comments

Steps to reproduce:

  • open a file
  • toggle blame gutter to show it
  • edit the file while blame gutter open
  • blame doesnt update and is therefore innacurate

alexcorre avatar May 19 '14 22:05 alexcorre

Closing this as of #31 when you save the file, blame is updated. thanks @dmnd

alexcorre avatar Sep 06 '14 20:09 alexcorre

I think this is still worth keeping open since updating in real time would be better what what I implemented in #31. But maybe #3 would cover it too.

dmnd avatar Sep 06 '14 20:09 dmnd

youre right. #3 is close but the two can be fixed independently. Will leave this one open. As far as #3 i started looking deeper into today and know what needs to be done. Itll take some change, but i'll submit a PR once its ready to get your feedback on the React stuff needed.

alexcorre avatar Sep 06 '14 21:09 alexcorre

Also want to make sure that editing outside the editor doesn't get overlooked. (e.g. checking out another version of the file while the file is open and git blame is visible in atom)

bblack avatar Sep 18 '14 18:09 bblack

@bblack can you open a separate issue for that? I think it's probably an easy fix given it already updates on save. It's probably just a matter of listening to the correct event.

dmnd avatar Sep 18 '14 18:09 dmnd

#36

bblack avatar Sep 18 '14 20:09 bblack