git-blame icon indicating copy to clipboard operation
git-blame copied to clipboard

Published 20 hours ago • verified publisher icon alexcorre

commit url breaks for private packages

Open chrishiestand opened this issue 9 years ago • 4 comments

Clicking on the commit id of a private project yields a 404 because of insufficient access.

Is it possible to open the URL in the default OS browser instead of an atom webview?

chrishiestand avatar Apr 22 '16 22:04 chrishiestand

This used to be possible in an older version of Atom, but the api for opening anchors with target="_blank" was removed at one point. They may have exposed a new API in recent versions. i'll check

alexcorre avatar Apr 26 '16 01:04 alexcorre

Also @chrishiestand you should be able to login to the private service from inside the atom webview as a stop gap. Is that possible?

alexcorre avatar Apr 26 '16 01:04 alexcorre

Yes, logging in is a workaround. I'd just prefer to not have atom authorized for my account.

Thanks for looking into it 👍

chrishiestand avatar Apr 26 '16 05:04 chrishiestand

@chrishiestand I've created a pull request that opens the url in your default browser. https://github.com/alexcorre/git-blame/pull/136

thaggie avatar May 14 '16 06:05 thaggie