Alex Couture-Beil

looking at the grpc logs, there's no errors in the stream, it just has a `Closing` message, which is showing up before the Read, which points back to some sort...

I tried adding counters around each ReadDir / ReadFile call under https://github.com/earthly/earthly/blob/a6201daa0bce56ebba09e80ba04a43219129678c/util/pcounter/pcounter.go to see if the buildFunc exited before all ReadDir / ReadFile calls finished, but none of the panics...

I revisited the idea of a race condition on the client side, and added some more printfs and it does not seem like it's the case: ``` 2024-03-01T22:52:55.6333488Z ControlClient().Solve on...

Here's a more complete log: ``` calling ControlClient().Solve on ref=htygtua6x9lrn8m863v3udo65 calling runGateway session.Run called by goroutine 185 [running]: runtime/debug.Stack() /usr/local/go/src/runtime/debug/stack.go:24 +0x5e github.com/moby/buildkit/session.(*Session).Run(0xc00018c380, {0x17c0140, 0xc00071cd70}, 0xc000593f50) /go/pkg/mod/github.com/earthly/[email protected]/session/session.go:113 +0x59 github.com/moby/buildkit/client.(*Client).solve.func1() /go/pkg/mod/github.com/earthly/[email protected]/client/solve.go:236 +0xcd...

This issue has proven to be difficult; we will look into cherry-picking security patches in the short term, and revisit syncing all upstream changes.

docker offers the ability to change this behaviour with the `--pull` cli option: ``` --pull string Pull image before running ("always", "missing", "never") ``` It would be nice if earthly...

there's a new repo that implements this: https://github.com/glehmann/tree-sitter-earthfile

2721c63ee6d923d6d801606913de47a90117c697 is a good example which shows what's needed to introduce a new feature flag.

This fix doesn't work, M1 users will get: ``` Error: running WITH DOCKER as a non-native CPU architecture. This is not supported. ```

You can also run this locally against any versions, e.g. this reproduces the error: ``` earthly=earthly-v0.8.10 crustly=earthly-v0.8.9 ./backwards-compatability.sh ``` which produces: ``` buildkitd | Found buildkit daemon as docker container...