[probe] clean-failed-payment after probe

[BhaagBoseDK]

bos probe does not clean-failed-payment (probes are essentially failed payments) after completion. It can do the same what bos rebalance does.

[alexbosworth]

what settings are you using? they use the same underlying probe function so I think it does clean the failed payment

[BhaagBoseDK]

as discussed in telegram, may be probe finishes and stops the process before the background task of cleaning payment can do its job. bos rebalance meanwhile has more attempts so previous failed payments are deleted. may be probe can wait a little before quitting?

Test Details

umbrel@umbrel:~/utils $ bos probe 03d06758583bb5154774a6eb221b1276c9e82d65bbaceca806d90e20c108f4b1c7 2169

checking_for_path_to: yalls.org yalls-tor 03d06758583bb5154774a6eb221b1276c9e82d65bbaceca806d90e20c108f4b1c7

evaluating: 
  - 726797x1025x1 ★ ★ ★ ★
  - ⚡️ ♎ 💰Z 🐒 yalls.org yalls-tor 03d06758583bb5154774a6eb221b1276c9e82d65bbaceca806d90e20c108f4b1c7. Fee rate: 0.00% (0)

fee:        0
latency_ms: 1319
probed:     2169
relays: 
  - 03d06758583bb5154774a6eb221b1276c9e82d65bbaceca806d90e20c108f4b1c7
success: 
  - 726797x1025x1

lnd log -> no clean failed payment.

2022-05-10 15:12:46.507 [WRN] CRTR: Attempt 907376 for payment 763df84ca1aa3bf08c0e7e1a010f915d34bffe39507d1d6d59b5367bef1d02c9 failed: IncorrectOrUnknownPaymentDetails(amt=2169000 mSAT, height=735779)@1
2022-05-10 15:12:46.522 [INF] CRTR: Payment 763df84ca1aa3bf08c0e7e1a010f915d34bffe39507d1d6d59b5367bef1d02c9 failed: final_outcome=incorrect_payment_details, raw_err=IncorrectOrUnknownPaymentDetails(amt=2169000 mSAT, height=735779)@1
2

Separately running bos clean-failed-payments finds and cleans this payment

umbrel@umbrel:~/utils $ bos clean-failed-payments

deleting_failed_payments: true

failed_payments: 1

2022-05-10 15:14:41.578 [INF] RPCS: [DeletePayment] payment_identifier=763df84ca1aa3bf08c0e7e1a010f915d34bffe39507d1d6d59b5367bef1d02c9, failed_htlcs_only=false