ng-notifications-bar icon indicating copy to clipboard operation
ng-notifications-bar copied to clipboard

Published 20 hours ago • verified publisher icon alexbeletsky

Check this please

Open SaulBurgos opened this issue 9 years ago • 4 comments
trafficstars

I have fixed a problem with the remove of notificators

SaulBurgos avatar Jan 27 '16 17:01 SaulBurgos

@SaulBurgos thanks a lot! Very likely the root cause is in this line. It's actually quite bad implementation there.

Instead of id it's possible to use a return value of push(), since it gives a new length of array, correspondingly index of notification is newLenght - 1 is an index of inserted notification. Then, it could be simply removed by index, not by id.

Would you like to take care of that?

alexbeletsky avatar Mar 22 '16 22:03 alexbeletsky

Hi guys, are there any plans to merge this PR to fix this issue soon?

GaryTowers avatar Nov 23 '16 15:11 GaryTowers

@alexbeletsky are you plan to merge this PR?

lciolecki avatar Dec 13 '16 11:12 lciolecki

bump?

davewood avatar Sep 19 '18 13:09 davewood