Alexandru Radovici

Results 97 comments of Alexandru Radovici

> As for lvgl, it asks the driver to adjust the buffer size, so it avoids the problem. > I'm not sure it actually can do that. I might be...

> > lvgl's render function may send any length of pixels and a position, depending on what it needs to refresh > > Yes, but also depending on what the...

> I appreciate incorporating some more high level feedback on my merge requests. > I'm not sure what do you mean by this. > From my point of view, however,...

> I'm happy that you tried to include some suggestions from me. > I tried to include the whole discussion that we had for #3047, I do have to include...

Great, I suggest we start with the tiles 😄 function.

The `register_structs` macro is indeed recursive. To prevent infinite loops, Rust has a [limit](https://doc.rust-lang.org/reference/attributes/limits.html) for the number of recursions that it will execute. You should be able to change it...

Even tough I'm not keen about the idea of duplicating offsets, not being able to write large register structures without modifying the upstream code is a problem. As I'm not...

I would be in favor of returning the temperature in hundreds of K. This would be in compliance with the standard measurement unit.

I think using hundreds of K should be fine as long as it is documented in the HIL.

I think this not entirely true, as the suggested change is to wrap the value in a `Result`, which will make the compiler show an error everywhere it is being...