github-webhook-listener icon indicating copy to clipboard operation
github-webhook-listener copied to clipboard

Webhook payloads without a ref field always get skipped

Open Slendy opened this issue 1 year ago • 1 comments

In my testing, I was attempting to trigger a workflow when a new registry package was published. No matter what I tried though the webhook would never trigger. After some digging, I discovered that the webhook payload doesn't contain a ref field which causes the ref check in shouldProcess to never return true. I got my situation to work by making the project ref nullable, but this is more of a temporary fix. Another potential solution could be checking that the ref field exists on the payload before checking it against the project ref.

Slendy avatar May 02 '24 03:05 Slendy

The project ref is used for selecting the right configuration to execute. In what cases is it null? And how do you see it behave?

Fixing this would probably require a configuration change. Any proposals?

alexandru avatar May 06 '24 16:05 alexandru