react-microsoft-login icon indicating copy to clipboard operation
react-microsoft-login copied to clipboard

Children property issue in typescript

Open vigneshRajenthiran opened this issue 2 years ago • 1 comments

Steps to reproduce:

  1. Installed the latest version of react-microsoft-login
  2. Rendered and tried to add children in the MicrosoftLogin component
  3. Got typescript error " property 'children' does not exist on type 'intrinsicattributes & microsoftloginprops'"

Attachments:

                                                                          <MicrosoftLogin
										clientId={office_clientId}
										graphScopes={graphScopes}
										prompt={'select_account'}
										useLocalStorageCache={true}
										authCallback={authHandler}
										buttonTheme={'dark'}
										children={
											 <Tooltip title={'One Drive'}>
												 <IconButton
												 	onClick={(e:any) => {
												 		folderClicked = true;
												 	}}
												 	color='inherit'
												 >
													<Office style={{ height: '20px', width: '20px' }} />
												</IconButton>
											 </Tooltip>
										}
									/>

vigneshRajenthiran avatar Jun 21 '22 12:06 vigneshRajenthiran

any update on this ?

Malin88 avatar Jul 11 '22 08:07 Malin88

No updates at December 16, 2022.

forge-oscar-caballero avatar Dec 16 '22 21:12 forge-oscar-caballero

I'm planning to start working on next version of this package to use new msal, this issue will be fixed in it

No timeframes I can share

alexandrtovmach avatar Dec 16 '22 22:12 alexandrtovmach

Fixed in v2.0.1

https://github.com/alexandrtovmach/react-microsoft-login/commit/851e81ea533b5cf95b733514c6f25c0c683a6f9a

alexandrtovmach avatar Feb 23 '23 19:02 alexandrtovmach