Results 67 comments of Alexandr Nikitin

I reviewed your recent changes. I'm still not sure that I get it. `CircuitBreakerOpenException` is meant to indicate that the circuit is open. `CircuitBreaker.Execute` throws an exception if execution fails...

Hi Jeffery, Thanks for the kind words! The documentations is very much wanted. But I'm not sure I can find time in near future. Regarding timeout, it depends, mostly on...

>It is possible to keep tests for example in src/test/scala directory? To answer the OP's (@tomqaz) question, the following code in `build.sbt` worked for me: ```scala sourceDirectory in Jmh :=...

@retronym It shouldn't be OS or Java version dependent. Does the `sbt '; project plugin; ^scripted'` execute the benchmark? I think no. You can reproduce it by running `sbt "jmh:run...

@abramsm Thank you. I'm ready to help with it. Basically I would just remove the overflow check. I can also introduce microbenchmarks to prevent regression. I just need an answer...

Hi @Kaotic3, Thank you for the issue. It throws the exception because the constructor gets an empty array of keywords. See here https://github.com/alexandrnikitin/AhoCorasick.Net/blob/0fead5e8f842b4a330282a5fb1929136a426e7cf/src/AhoCorasick.Net/AhoCorasickTree.cs#L14 I assume uniqueWords hence wordArray is empty....

Yes, it looks like the uniqueWords list is empty and not populated. Please populate it in the benchmark constructor or Setup method. See [Benchmark.NET docs](https://benchmarkdotnet.org/articles/features/setup-and-cleanup.html). It doesn't throw in the...

Yes, it looks like the list is populated outside of the benchmark. No problem. Feel free to ask any question.

Any updates on this? It would be great to have easier navigation.