temporal-operator icon indicating copy to clipboard operation
temporal-operator copied to clipboard

Allow overriding admintools image tag

Open chulkilee opened this issue 1 year ago • 3 comments

https://github.com/alexandrevilain/temporal-operator/blob/v0.19.0/internal/resource/persistence/schema_setup_job_builder.go#L126

temporalio/admintools for 1.23.1 is missing in the docker hub (link) - but temporal-operator always uses cluster version as the tag, thus I cannot deploy new cluster (unless the k8s node has the pulled image 😉 )

Probably we can do the same changes for all other images where image is configurable.

Update: reported https://github.com/temporalio/docker-builds/issues/237

chulkilee avatar Aug 16 '24 16:08 chulkilee

Hi!

Thanks for reporting this issue. This will be addressed in: https://github.com/alexandrevilain/temporal-operator/pull/760

alexandrevilain avatar Aug 16 '24 20:08 alexandrevilain

I created PR #789 because I couldn’t wait for #760 - since it is blocking the launch of a new cluster.

chulkilee avatar Aug 16 '24 20:08 chulkilee

Got hit with this as well, was able to work around by vendoring the container with a new tag, and updating the image to point to internal repo but definitely need a way to change tags for admintools since they seem to be released with very odd tags now.

plaisted avatar Sep 04 '24 21:09 plaisted