muse-lsl icon indicating copy to clipboard operation
muse-lsl copied to clipboard

Muse lsl connection timeout argument

Open aureateAnatidae opened this issue 1 year ago • 0 comments

Either my laptop is slow or it's because I have an original muse, it seems to have an issue timing out before it can establish a connection. This pull request adds a -t --timeout argument to the argument parser, allowing my machine to try connecting for longer before the timeout argument.

Also, a variable setting the default timeout length AUTO_DISCONNECT_DELAY in constants.py was commented out, and its only use was in stream.py has been deleted. The default timeout length was set in the argument parsers in cli.py (10.0) to relieve its role. Please be wary that the connection timeout and scan timeout are different variables addressed by the same name. This pull request addresses the former.

I only have the means to test this with bluetoothctl/bleak, so I'm kinda just hoping it doesn't break something sending a timeout argument to gatt or hci or windows or something. I've been using python 3.11 on Debian 12, bluetoothctl 5.66.

I've never done this kind of open-source thing, so please provide advice liberally :).

Should resolve #178

Hadn't noticed this other person's issue before, but glad someone else mentioned it.

aureateAnatidae avatar Sep 22 '23 23:09 aureateAnatidae